Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report UntilInsteadOfRangeTo for 'rangeTo' calls #4212

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Report UntilInsteadOfRangeTo for 'rangeTo' calls #4212

merged 2 commits into from
Nov 1, 2021

Conversation

t-kameyama
Copy link
Contributor

Fixes #4207

@codecov
Copy link

codecov bot commented Oct 31, 2021 •
edited
Loading

Codecov Report

Merging #4212 (3787c10) into main (795ed03) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4212   +/-   ##
=========================================
  Coverage     84.24%   84.25%           
- Complexity     3243     3245    +2     
=========================================
  Files           468      468           
  Lines         10176    10179    +3     
  Branches       1786     1785    -1     
=========================================
+ Hits           8573     8576    +3     
  Misses          658      658           
  Partials        945      945
Impacted Files Coverage Δ
...rbosch/detekt/rules/style/UntilInsteadOfRangeTo.kt 80.95% <75.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795ed03...3787c10. Read the comment docs.

cortinico
cortinico approved these changes Oct 31, 2021
View reviewed changes
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nit

@t-kameyama @cortinico
Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt…
3787c10 
…/rules/style/UntilInsteadOfRangeTo.kt

Co-authored-by: Nicola Corti <corti.nico@gmail.com>
@cortinico cortinico added this to the 1.19.0 milestone Oct 31, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Oct 31, 2021
@chao2zhang chao2zhang merged commit 3fee5d0 into detekt:main Nov 1, 2021
@t-kameyama t-kameyama deleted the issue_4207 branch November 1, 2021 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chao2zhang chao2zhang chao2zhang approved these changes

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.

UntilInsteadOfRangeTo doesn't report when rangeTo is used
3 participants
@t-kameyama @chao2zhang @cortinico