Skip to content

Simplify where casts used unnecessarily - #4213

Merged
3flex merged 1 commit into
detekt:mainfrom
3flex:unnecessary-casts
Oct 31, 2021
Merged

Simplify where casts used unnecessarily#4213
3flex merged 1 commit into
detekt:mainfrom
3flex:unnecessary-casts

Conversation

@3flex

@3flex 3flex commented Oct 31, 2021

Copy link
Copy Markdown
Member

No description provided.

@3flex
3flex force-pushed the unnecessary-casts branch from 325db4d to 15dea8a Compare October 31, 2021 11:59
@cortinico

Copy link
Copy Markdown
Member

Looks good from the code point of view, but the CI is red. Should this be converted to a draft PR?

@codecov

codecov Bot commented Oct 31, 2021

Copy link
Copy Markdown

Codecov Report

Merging #4213 (489ca8f) into main (795ed03) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4213      +/-   ##
============================================
+ Coverage     84.24%   84.27%   +0.02%     
+ Complexity     3243     3242       -1     
============================================
  Files           468      468              
  Lines         10176    10173       -3     
  Branches       1786     1782       -4     
============================================
  Hits           8573     8573              
  Misses          658      658              
+ Partials        945      942       -3     
Impacted Files Coverage Δ
...detekt/rules/bugs/DoubleMutabilityForCollection.kt 85.18% <0.00%> (-0.53%) ⬇️
...rbosch/detekt/rules/style/RedundantExplicitType.kt 67.64% <0.00%> (ø)
...h/detekt/rules/naming/MemberNameEqualsClassName.kt 87.50% <100.00%> (+2.13%) ⬆️
...sch/detekt/rules/style/UnnecessaryAbstractClass.kt 84.78% <100.00%> (+2.17%) ⬆️
...tlab/arturbosch/detekt/rules/style/UseDataClass.kt 78.57% <100.00%> (+1.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795ed03...489ca8f. Read the comment docs.

@3flex
3flex force-pushed the unnecessary-casts branch from 15dea8a to 489ca8f Compare October 31, 2021 12:08
@3flex

3flex commented Oct 31, 2021

Copy link
Copy Markdown
Member Author

the CI is red

Green now, except for Codecov complaining.

@cortinico cortinico added this to the 1.19.0 milestone Oct 31, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Oct 31, 2021
@3flex
3flex merged commit 8e93734 into detekt:main Oct 31, 2021
@3flex
3flex deleted the unnecessary-casts branch October 31, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants