Simplify where casts used unnecessarily - #4213
Merged
Merged
Conversation
3flex
force-pushed
the
unnecessary-casts
branch
from
October 31, 2021 11:59
325db4d to
15dea8a
Compare
Member
|
Looks good from the code point of view, but the CI is red. Should this be converted to a draft PR? |
Codecov Report
@@ Coverage Diff @@
## main #4213 +/- ##
============================================
+ Coverage 84.24% 84.27% +0.02%
+ Complexity 3243 3242 -1
============================================
Files 468 468
Lines 10176 10173 -3
Branches 1786 1782 -4
============================================
Hits 8573 8573
Misses 658 658
+ Partials 945 942 -3
Continue to review full report at Codecov.
|
3flex
force-pushed
the
unnecessary-casts
branch
from
October 31, 2021 12:08
15dea8a to
489ca8f
Compare
Member
Author
Green now, except for Codecov complaining. |
cortinico
approved these changes
Oct 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.