Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify conditional checks to improve coverage #4221

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Conversation

3flex
Copy link
Member

@3flex 3flex commented Nov 1, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #4221 (47258fc) into main (7d46753) will increase coverage by 0.05%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4221      +/-   ##
============================================
+ Coverage     84.27%   84.33%   +0.05%     
+ Complexity     3244     3242       -2     
============================================
  Files           468      468              
  Lines         10176    10169       -7     
  Branches       1781     1777       -4     
============================================
  Hits           8576     8576              
  Misses          658      658              
+ Partials        942      935       -7     
Impacted Files Coverage Δ
.../arturbosch/detekt/rules/naming/NoNameShadowing.kt 69.69% <0.00%> (+1.12%) ⬆️
...s/performance/UnnecessaryTemporaryInstantiation.kt 84.61% <0.00%> (+6.04%) ⬆️
...osch/detekt/rules/style/CollapsibleIfStatements.kt 92.85% <100.00%> (+11.60%) ⬆️
...itlab/arturbosch/detekt/rules/style/MagicNumber.kt 91.20% <100.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d46753...47258fc. Read the comment docs.

@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Nov 1, 2021
@cortinico cortinico added this to the 1.19.0 milestone Nov 1, 2021
@3flex 3flex merged commit 56471bf into detekt:main Nov 1, 2021
@3flex 3flex deleted the refactor4 branch November 1, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants