Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support full qualified names in AnnotationSuppressor #4241

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Conversation

BraisGabin
Copy link
Member

This add supports to full qualified name matching in AnnotationSuppresor. It also allow Glob patterns.

Fixes #4233

@BraisGabin
Copy link
Member Author

cc @TWiStErRob. This was exactly what we talk about at the Droidcon. As you can see it's not as "clean" as before but now you can use both name or full qualified names.

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #4241 (0f1eb53) into main (a47a32c) will increase coverage by 0.06%.
The diff coverage is 79.16%.

❗ Current head 0f1eb53 differs from pull request most recent head 72e69fc. Consider uploading reports for the commit 72e69fc to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4241      +/-   ##
============================================
+ Coverage     84.24%   84.30%   +0.06%     
+ Complexity     3258     3243      -15     
============================================
  Files           472      470       -2     
  Lines         10293    10233      -60     
  Branches       1813     1793      -20     
============================================
- Hits           8671     8627      -44     
+ Misses          666      663       -3     
+ Partials        956      943      -13     
Impacted Files Coverage Δ
...ch/detekt/core/suppressors/AnnotationSuppressor.kt 80.00% <76.19%> (-10.00%) ⬇️
...otlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt 81.81% <100.00%> (ø)
.../arturbosch/detekt/core/suppressors/Suppressors.kt 100.00% <100.00%> (ø)
...gitlab/arturbosch/detekt/rules/KtCallExpression.kt 0.00% <0.00%> (-33.34%) ⬇️
...urbosch/detekt/rules/style/UselessCallOnNotNull.kt 88.09% <0.00%> (-1.04%) ⬇️
...rturbosch/detekt/rules/style/OptionalWhenBraces.kt 93.33% <0.00%> (-0.42%) ⬇️
...turbosch/detekt/rules/style/UnusedPrivateMember.kt 92.45% <0.00%> (-0.19%) ⬇️
...tlab/arturbosch/detekt/rules/KtBinaryExpression.kt 0.00% <0.00%> (ø)
...rturbosch/detekt/rules/style/StyleGuideProvider.kt 100.00% <0.00%> (ø)
...osch/detekt/rules/coroutines/CoroutinesProvider.kt 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a47a32c...72e69fc. Read the comment docs.

Copy link
Member

@TWiStErRob TWiStErRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks for the cc. It looks ok, I agree with doing the best possible based on binding context or not.

@BraisGabin BraisGabin force-pushed the fix-4233 branch 2 times, most recently from 0ead692 to 59f97d9 Compare November 8, 2021 18:49
@BraisGabin BraisGabin added this to the 1.19.0 milestone Nov 10, 2021
@BraisGabin BraisGabin merged commit f841249 into main Nov 16, 2021
@BraisGabin BraisGabin deleted the fix-4233 branch November 16, 2021 10:03
@cortinico cortinico added the notable changes Marker for notable changes in the changelog label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable changes Marker for notable changes in the changelog suppressors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support full qualified names for annotations in ignoreAnnotated
3 participants