-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support full qualified names in AnnotationSuppressor #4241
Conversation
cc @TWiStErRob. This was exactly what we talk about at the Droidcon. As you can see it's not as "clean" as before but now you can use both name or full qualified names. |
Codecov Report
@@ Coverage Diff @@
## main #4241 +/- ##
============================================
+ Coverage 84.24% 84.30% +0.06%
+ Complexity 3258 3243 -15
============================================
Files 472 470 -2
Lines 10293 10233 -60
Branches 1813 1793 -20
============================================
- Hits 8671 8627 -44
+ Misses 666 663 -3
+ Partials 956 943 -13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thanks for the cc. It looks ok, I agree with doing the best possible based on binding context or not.
...kt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/suppressors/AnnotationSuppressor.kt
Outdated
Show resolved
Hide resolved
0ead692
to
59f97d9
Compare
This add supports to full qualified name matching in
AnnotationSuppresor
. It also allow Glob patterns.Fixes #4233