Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptionalWhenBraces: fix false negative for nested when #4246

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

t-kameyama
Copy link
Contributor

Fixes #4245

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #4246 (3d3ab32) into main (deab0fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4246   +/-   ##
=========================================
  Coverage     84.32%   84.32%           
  Complexity     3243     3243           
=========================================
  Files           470      470           
  Lines         10222    10223    +1     
  Branches       1787     1787           
=========================================
+ Hits           8620     8621    +1     
  Misses          663      663           
  Partials        939      939           
Impacted Files Coverage Δ
...rturbosch/detekt/rules/style/OptionalWhenBraces.kt 93.75% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deab0fe...3d3ab32. Read the comment docs.

@BraisGabin BraisGabin merged commit 6e20321 into detekt:main Nov 9, 2021
@t-kameyama t-kameyama deleted the issue_4245 branch November 9, 2021 08:07
@cortinico cortinico added this to the 1.19.0 milestone Nov 9, 2021
@cortinico cortinico added the rules label Nov 9, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OptionalWhenBraces false negative for nested when wrapped in braces
3 participants