Introduce UseAnyOrNoneInsteadOfFind rule #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-kameyama
force-pushed
the
issue_4243
branch
from
3094699
to
a1008d9
Compare
BraisGabin
reviewed
Nov 9, 2021
...yle/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UseAnyOrNoneInsteadOfFindSpec.kt
Show resolved
Hide resolved
...yle/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UseAnyOrNoneInsteadOfFindSpec.kt
Show resolved
Hide resolved
|
As always, thanks for the contributions :) |
Codecov Report
@@ Coverage Diff @@
## main #4247 +/- ##
============================================
- Coverage 84.32% 84.29% -0.04%
- Complexity 3243 3253 +10
============================================
Files 470 471 +1
Lines 10223 10261 +38
Branches 1787 1804 +17
============================================
+ Hits 8621 8649 +28
- Misses 663 664 +1
- Partials 939 948 +9
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Nov 9, 2021
cortinico
approved these changes
Nov 9, 2021
| it("Reports collections.find != null") { | ||
| val code = "val x = listOf(1, 2, 3).find { it == 4 } != null" | ||
| val actual = subject.compileAndLintWithContext(env, code) | ||
| Assertions.assertThat(actual).hasSize(1) |
There was a problem hiding this comment.
Can you import org.assertj.core.api.Assertions.assertThat so you won't have to repeat it in all the test?
t-kameyama
force-pushed
the
issue_4243
branch
from
bc5c111
to
f1174c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4243