Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove afterEvaluate wrapper (#4159)" #4259

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Revert "Remove afterEvaluate wrapper (#4159)" #4259

merged 1 commit into from
Nov 12, 2021

Conversation

BraisGabin
Copy link
Member

For more context read #4253

fixes #4253
fixes #4250

@BraisGabin BraisGabin added this to the 1.19.0 milestone Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #4259 (842ad0e) into main (c6f796a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4259   +/-   ##
=========================================
  Coverage     84.27%   84.27%           
  Complexity     3249     3249           
=========================================
  Files           471      471           
  Lines         10261    10261           
  Branches       1805     1805           
=========================================
  Hits           8647     8647           
  Misses          664      664           
  Partials        950      950           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f796a...842ad0e. Read the comment docs.

@cortinico
Copy link
Member

We should recall to update the changelog if this lands

@BraisGabin BraisGabin merged commit 534521c into main Nov 12, 2021
@BraisGabin BraisGabin deleted the fix-4253 branch November 12, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants