Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of deprecated ConfigureUtil #4263

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

3flex
Copy link
Member

@3flex 3flex commented Nov 14, 2021

ConfigureUtil is planned for removal in Gradle 8.0.

Use of Closure has been discouraged for some time. It can be replaced with Action ; https://docs.gradle.org/current/userguide/kotlin_dsl.html#groovy_closures_from_kotlin

Gradle plugins written in any language should prefer the type Action<T> type in place of closures. Groovy closures and Kotlin lambdas are automatically mapped to arguments of that type.

@chao2zhang chao2zhang merged commit 6605afe into detekt:main Nov 15, 2021
@3flex 3flex added this to the 1.19.0 milestone Nov 15, 2021
@cortinico
Copy link
Member

Use of Closure has been discouraged for some time. It can be replaced with Action ; docs.gradle.org/current/userguide/kotlin_dsl.html#groovy_closures_from_kotlin

Is this going to be a breaking change for any of our user (from the Groovy or Kotlin point of view)? I just wanted to know so this can be pointed out in the release notes.

@3flex 3flex deleted the gradle-deprecation branch November 15, 2021 22:52
@3flex
Copy link
Member Author

3flex commented Nov 15, 2021

Is this going to be a breaking change for any of our user

There shouldn't be any breaking change, as Gradle will transparently do what's needed in the background so either Groovy closure or Kotlin lambda will be mapped to the Action automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants