Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use appropriate annotations on source properties in Gradle tasks #4264

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

3flex
Copy link
Member

@3flex 3flex commented Nov 14, 2021

No description provided.

…task

Specifies that directories should not be considered during build cache and
up-to-date checks.
Copy link
Member

@chao2zhang chao2zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the addition of @IgnoreEmptyDirectories to prevent known bugs?

@3flex
Copy link
Member Author

3flex commented Nov 15, 2021

Was the addition of @IgnoreEmptyDirectories to prevent known bugs?

No, no bugs. It just means that when input files are snapshot for up to date checks that empty directories will be ignored, increasing performance if the only change in the source was the inclusion (or removal) of an empty directory.

getSource on SourceTask has had the annotation since Gradle 6.8, but it needs to be added here to take effect since we're overriding to update the path sensitivity annotation.

@chao2zhang
Copy link
Member

Something I learned is that we override the path sensitivity in #2182. I guess this can be useful if we are exploring remote build cache in the future.

@chao2zhang chao2zhang merged commit 750c680 into detekt:main Nov 15, 2021
@3flex 3flex deleted the gradle-annotation branch November 15, 2021 06:27
@3flex 3flex added this to the 1.19.0 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants