Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertJ 3.23.1 #4265

Merged
merged 1 commit into from Jul 18, 2022
Merged

AssertJ 3.23.1 #4265

merged 1 commit into from Jul 18, 2022

Conversation

3flex
Copy link
Collaborator

@3flex 3flex commented Nov 14, 2021

Stacks on #4821 - do not merge until that is merged.

@3flex 3flex added the dependencies Pull requests that update a dependency file label Nov 14, 2021
@3flex
Copy link
Collaborator Author

3flex commented Nov 14, 2021

Failing due to: assertj/assertj#2357, root cause is KT-17765.

The workarounds aren't very nice, so it might be best to stay on 3.20.2 for now.

@3flex 3flex closed this Nov 14, 2021
@3flex 3flex changed the title AssertJ 3.12.0 AssertJ 3.21.0 Nov 19, 2021
@3flex 3flex deleted the update-assertj branch November 19, 2021 05:08
@3flex 3flex restored the update-assertj branch November 30, 2021 23:28
@3flex
Copy link
Collaborator Author

3flex commented Nov 30, 2021

KT-17765 should be fixed in Kotlin 1.6.20, so when that is released it should be possible to rebase and merge.

@3flex 3flex reopened this Nov 30, 2021
@3flex 3flex added the blocked label Nov 30, 2021
@3flex 3flex changed the title AssertJ 3.21.0 AssertJ 3.22.0 Jan 6, 2022
@3flex 3flex force-pushed the update-assertj branch 7 times, most recently from 85781cf to 3b8bddf Compare February 8, 2022 21:32
@3flex
Copy link
Collaborator Author

3flex commented Feb 8, 2022

Though KT-17765 seems fixed in Kotlin 1.6.20-M1 it requires using experimental language version 1.7, e.g.:

tasks.compileTestKotlin {
    kotlinOptions.languageVersion = "1.7"
}

We could enable this for test tasks only, but as it's considered experimental, I think it's better to hold back on this until the fix goes stable in Kotlin 1.7. Using the older AssertJ version doesn't block anything.

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #4265 (e382a35) into main (4015679) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4265   +/-   ##
=========================================
  Coverage     84.92%   84.92%           
  Complexity     3605     3605           
=========================================
  Files           502      502           
  Lines         11873    11873           
  Branches       2227     2227           
=========================================
  Hits          10083    10083           
  Misses          691      691           
  Partials       1099     1099           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4015679...e382a35. Read the comment docs.

@BraisGabin BraisGabin added this to the 1.22.0 milestone Jun 12, 2022
@3flex 3flex removed the blocked label Jul 18, 2022
@3flex 3flex merged commit 675f62f into detekt:main Jul 18, 2022
21 checks passed
VitalyVPinchuk pushed a commit to VitalyVPinchuk/detekt that referenced this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants