-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssertJ 3.23.1 #4265
AssertJ 3.23.1 #4265
Conversation
Failing due to: assertj/assertj#2357, root cause is KT-17765. The workarounds aren't very nice, so it might be best to stay on 3.20.2 for now. |
KT-17765 should be fixed in Kotlin 1.6.20, so when that is released it should be possible to rebase and merge. |
85781cf
to
3b8bddf
Compare
Though KT-17765 seems fixed in Kotlin 1.6.20-M1 it requires using experimental language version 1.7, e.g.: tasks.compileTestKotlin {
kotlinOptions.languageVersion = "1.7"
} We could enable this for test tasks only, but as it's considered experimental, I think it's better to hold back on this until the fix goes stable in Kotlin 1.7. Using the older AssertJ version doesn't block anything. |
Codecov Report
@@ Coverage Diff @@
## main #4265 +/- ##
=========================================
Coverage 84.92% 84.92%
Complexity 3605 3605
=========================================
Files 502 502
Lines 11873 11873
Branches 2227 2227
=========================================
Hits 10083 10083
Misses 691 691
Partials 1099 1099 Continue to review full report at Codecov.
|
Stacks on #4821 - do not merge until that is merged.