Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tests of UnnecesaryLet #4282

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Improve Tests of UnnecesaryLet #4282

merged 2 commits into from
Nov 18, 2021

Conversation

BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Nov 16, 2021

I know that the diff is a bit big but the first commit just moved a test up and rename other ones to keep the number. And the second moves two tests outside the context of tests related with deconstructing arguments.

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Nov 16, 2021
@BraisGabin BraisGabin changed the title Improve UnnecesaryLetTests Improve Tests of UnnecesaryLet Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #4282 (5b2e3e5) into main (c66b8d6) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5b2e3e5 differs from pull request most recent head 6997db0. Consider uploading reports for the commit 6997db0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4282   +/-   ##
=========================================
  Coverage     84.22%   84.22%           
  Complexity     3258     3258           
=========================================
  Files           472      472           
  Lines         10309    10309           
  Branches       1820     1820           
=========================================
  Hits           8683     8683           
  Misses          666      666           
  Partials        960      960           
Impacted Files Coverage Δ
...ab/arturbosch/detekt/rules/style/UnnecessaryLet.kt 80.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c66b8d6...6997db0. Read the comment docs.

Base automatically changed from fix-typo to main November 17, 2021 08:03
@chao2zhang chao2zhang added this to the 1.19.0 milestone Nov 18, 2021
@BraisGabin BraisGabin merged commit cef8827 into main Nov 18, 2021
@BraisGabin BraisGabin deleted the improve-unnecesary-let branch November 18, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants