Add functional test for type resolution for JVM#4307
Merged
3flex merged 1 commit intodetekt:mainfrom Nov 20, 2021
Merged
Conversation
3flex
force-pushed
the
functionalTest
branch
from
5a2dc18 to
b048462
Compare
BraisGabin
approved these changes
Nov 19, 2021
Member
|
I agree with you that maybe, for more complex cases this could explote. But have at least some tests like this would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple functional test for type resolution on JVM, checking that both Kotlin & Java types are being checked.
I have used the complete file structure instead of using the helpers in the test-fixtures module. Although this test is simple, when we start adding functional tests for more complex project structures, building it out from code like the existing TestKit tests is (IMHO) going to get out of hand. I always get a bit lost when reviewing the existing tests due to the heavy use of parameters & functions to build out the build file & modules.
I intend to add other tests (Android, multiplatform) using the same structure as used here, assuming agreement on the approach.