Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional test for type resolution for JVM #4307

Merged
merged 1 commit into from
Nov 20, 2021

Conversation

3flex
Copy link
Member

@3flex 3flex commented Nov 19, 2021

This is a simple functional test for type resolution on JVM, checking that both Kotlin & Java types are being checked.

I have used the complete file structure instead of using the helpers in the test-fixtures module. Although this test is simple, when we start adding functional tests for more complex project structures, building it out from code like the existing TestKit tests is (IMHO) going to get out of hand. I always get a bit lost when reviewing the existing tests due to the heavy use of parameters & functions to build out the build file & modules.

I intend to add other tests (Android, multiplatform) using the same structure as used here, assuming agreement on the approach.

@3flex 3flex added the housekeeping Marker for housekeeping tasks and refactorings label Nov 19, 2021
@BraisGabin
Copy link
Member

I agree with you that maybe, for more complex cases this could explote. But have at least some tests like this would be great.

@3flex 3flex merged commit acd4c37 into detekt:main Nov 20, 2021
@3flex 3flex deleted the functionalTest branch November 20, 2021 02:18
@cortinico cortinico added this to the 1.19.0 milestone Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants