Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide null issues #4313

Merged
merged 2 commits into from
Nov 20, 2021
Merged

Don't hide null issues #4313

merged 2 commits into from
Nov 20, 2021

Conversation

BraisGabin
Copy link
Member

getResource and getResourceAsStream can return a null value But they are java functions so the compiler doesn't complain about it.

This PR only shows clearly in the code where we could have a NullPointerException.

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Nov 20, 2021
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #4313 (a7f2a2d) into main (d257c2a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4313   +/-   ##
=========================================
  Coverage     84.22%   84.22%           
  Complexity     3258     3258           
=========================================
  Files           472      472           
  Lines         10309    10309           
  Branches       1820     1820           
=========================================
  Hits           8683     8683           
  Misses          666      666           
  Partials        960      960           
Impacted Files Coverage Δ
...lab/arturbosch/detekt/core/config/DefaultConfig.kt 100.00% <100.00%> (ø)
...bosch/detekt/core/tooling/DefaultConfigProvider.kt 80.00% <100.00%> (ø)
...n/io/github/detekt/report/html/HtmlOutputReport.kt 95.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d257c2a...a7f2a2d. Read the comment docs.

@cortinico cortinico added this to the 1.19.0 milestone Nov 20, 2021
@BraisGabin BraisGabin merged commit 5f9e4a5 into main Nov 20, 2021
@BraisGabin BraisGabin deleted the dont-hide-nulls branch November 20, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants