Move tests to the correct module#4314
Merged
Merged
Conversation
BraisGabin
force-pushed
the
improve-test-default-config
branch
from
November 20, 2021 17:39
b9fcf28 to
317c8ae
Compare
Codecov Report
@@ Coverage Diff @@
## main #4314 +/- ##
=========================================
Coverage 84.22% 84.22%
Complexity 3258 3258
=========================================
Files 472 472
Lines 10309 10309
Branches 1820 1820
=========================================
Hits 8683 8683
Misses 666 666
Partials 960 960 Continue to review full report at Codecov.
|
BraisGabin
force-pushed
the
improve-test-default-config
branch
from
November 20, 2021 19:50
317c8ae to
701fd55
Compare
schalkms
approved these changes
Nov 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were checking that the
detekt-default-configfile were correct indetekt-core. But it is generated indetekt-generate. It have more sense to test that the file is created correctly indetekt-generatethan indetekt-core. In any case these tests are a bit strange.