Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4334 +/- ##
============================================
- Coverage 84.23% 84.23% -0.01%
Complexity 3258 3258
============================================
Files 474 473 -1
Lines 10322 10319 -3
Branches 1824 1823 -1
============================================
- Hits 8695 8692 -3
- Misses 666 667 +1
+ Partials 961 960 -1
Continue to review full report at Codecov.
|
picklebento
approved these changes
Nov 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
ForbiddenMethodCallby default and then it addsUrl.openStreamandClass.getResourceAsStreamto the list.We need to add support to a description for each forbidden method. If someone in one year find this will now know about the existence of the "safe" version.
I'm creating a new module
detekt-utils. The problem is thatdetekt-toolingare toolings related with the compiler and I couldn't add it anywhere becuase I was introducting circular dependenciees. Thisdetekt-utilsis a more basic module. Right now it only contains one file to avoid those extrange behaviours when usingUrl.openStream()andClass.openResourceAsStream().I'm not a big fan to create another module but I don't know how to fix this otherwise.