Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
ForbiddenMethodCall
by default and then it addsUrl.openStream
andClass.getResourceAsStream
to the list.We need to add support to a description for each forbidden method. If someone in one year find this will now know about the existence of the "safe" version.
I'm creating a new module
detekt-utils
. The problem is thatdetekt-tooling
are toolings related with the compiler and I couldn't add it anywhere becuase I was introducting circular dependenciees. Thisdetekt-utils
is a more basic module. Right now it only contains one file to avoid those extrange behaviours when usingUrl.openStream()
andClass.openResourceAsStream()
.I'm not a big fan to create another module but I don't know how to fix this otherwise.