Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim values when parsing the baseline #4335

Merged
merged 3 commits into from
Nov 26, 2021
Merged

trim values when parsing the baseline #4335

merged 3 commits into from
Nov 26, 2021

Conversation

BraisGabin
Copy link
Member

Out baseline should treat this:

<ID>
  FeatureEnvy:Signature
</ID>

The same way it treats:

<ID>FeatureEnvy:Signature</ID>

This PR ensures that.

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #4335 (96e0d43) into main (a1150bc) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4335   +/-   ##
=========================================
  Coverage     84.23%   84.23%           
- Complexity     3258     3259    +1     
=========================================
  Files           474      474           
  Lines         10322    10323    +1     
  Branches       1824     1825    +1     
=========================================
+ Hits           8695     8696    +1     
  Misses          666      666           
  Partials        961      961           
Impacted Files Coverage Δ
...arturbosch/detekt/core/baseline/BaselineHandler.kt 95.00% <50.00%> (ø)
...h/detekt/rules/naming/MemberNameEqualsClassName.kt 87.80% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1150bc...96e0d43. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants