[UseDataClass] Do not report on inner classes#4344
Merged
cortinico merged 2 commits intodetekt:mainfrom Dec 1, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4344 +/- ##
=========================================
Coverage 84.23% 84.24%
- Complexity 3259 3262 +3
=========================================
Files 474 474
Lines 10323 10326 +3
Branches 1825 1827 +2
=========================================
+ Hits 8696 8699 +3
Misses 666 666
Partials 961 961
Continue to review full report at Codecov.
|
inner classes
cortinico
approved these changes
Nov 30, 2021
BraisGabin
approved these changes
Dec 1, 2021
Member
|
@cortinico is that milestone correct? Shouldn't it be 1.20.0? |
Member
Yup my bad. Let me close 1.19.0 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
UseDataClassrule reports to use thedatakeyword on inner classes. Sincedatais incompatible withinnerthis PR fixes the behaviour.