Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely-empty abstract classes will now be flagged by UnnecessaryAbstractClass #4370

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

severn-everett
Copy link
Contributor

This resolves issue #4357

@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #4370 (b9d6716) into main (92433ea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4370   +/-   ##
=========================================
  Coverage     84.26%   84.27%           
+ Complexity     3263     3261    -2     
=========================================
  Files           473      473           
  Lines         10336    10336           
  Branches       1827     1827           
=========================================
+ Hits           8710     8711    +1     
  Misses          667      667           
+ Partials        959      958    -1     
Impacted Files Coverage Δ
...sch/detekt/rules/style/UnnecessaryAbstractClass.kt 86.95% <100.00%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92433ea...b9d6716. Read the comment docs.

@schalkms schalkms merged commit a9ce1e2 into detekt:main Dec 15, 2021
@schalkms schalkms added this to the 1.20.0 milestone Dec 15, 2021
@severn-everett severn-everett deleted the standardize_unnecessary_abstract branch December 16, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants