Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary map lambda in test code #4397

Merged
merged 1 commit into from
Dec 26, 2021
Merged

Remove unnecessary map lambda in test code #4397

merged 1 commit into from
Dec 26, 2021

Conversation

schalkms
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #4397 (d6e7e7c) into main (48a28fc) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4397      +/-   ##
============================================
+ Coverage     84.23%   84.33%   +0.10%     
- Complexity     3259     3272      +13     
============================================
  Files           474      473       -1     
  Lines         10323    10351      +28     
  Branches       1825     1826       +1     
============================================
+ Hits           8696     8730      +34     
- Misses          666      668       +2     
+ Partials        961      953       -8     
Impacted Files Coverage Δ
.../gitlab/arturbosch/detekt/rules/empty/EmptyRule.kt 92.30% <0.00%> (-3.15%) ⬇️
...etekt/rules/style/optional/MandatoryBracesLoops.kt 73.33% <0.00%> (-2.53%) ⬇️
...ab/arturbosch/detekt/core/config/ValidateConfig.kt 98.64% <0.00%> (-1.36%) ⬇️
...n/kotlin/io/gitlab/arturbosch/detekt/api/Entity.kt 75.00% <0.00%> (-1.20%) ⬇️
.../gitlab/arturbosch/detekt/api/internal/Versions.kt 87.50% <0.00%> (ø)
...n/io/github/detekt/report/html/HtmlOutputReport.kt 95.55% <0.00%> (ø)
.../arturbosch/detekt/generator/out/AbstractWriter.kt 0.00% <0.00%> (ø)
.../detekt/rules/exceptions/ObjectExtendsThrowable.kt 80.95% <0.00%> (ø)
...lin/io/github/detekt/tooling/internal/Resources.kt
...turbosch/detekt/rules/style/UnusedPrivateMember.kt 92.68% <0.00%> (+0.04%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a28fc...d6e7e7c. Read the comment docs.

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a rule to detect this? Probably worth it.

@schalkms
Copy link
Member Author

Nope, there isn't. Otherwise, detekt would have detected this snippet.😉

Do we have a rule to detect this? Probably worth it.

@schalkms schalkms merged commit 10e8bf5 into main Dec 26, 2021
@schalkms schalkms deleted the refactor branch December 26, 2021 20:24
@schalkms schalkms added this to the 1.20.0 milestone Dec 27, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants