Fix false-positive on ExplicitCollectionElementAccessMethod

[BraisGabin]

This fixes the issue raised con #4288 implementing the solution proposed in this comment: #4288 (comment):

Alternatively, we can report only when the set/get has exactly one parameter for the key.

In this case I'm just checking for the set case because I think that all the cases for get should work as expected.

fixes #4288

[codecov]

Codecov Report

Merging #4400 (0da9400) into main (8a919d9) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 0da9400 differs from pull request most recent head 45c32ca. Consider uploading reports for the commit 45c32ca to get more accurate results

@@             Coverage Diff              @@
##               main    #4400      +/-   ##
============================================
- Coverage     84.35%   84.35%   -0.01%     
- Complexity     3277     3279       +2     
============================================
  Files           473      473              
  Lines         10357    10361       +4     
  Branches       1827     1829       +2     
============================================
+ Hits           8737     8740       +3     
  Misses          668      668              
- Partials        952      953       +1     

Impacted Files	Coverage Δ
...les/style/ExplicitCollectionElementAccessMethod.kt	63.63% <50.00%> (+1.56%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aef4cf9...45c32ca. Read the comment docs.

[schalkms]

Here you check for the parameter list size to be bigger than 2, but in the test case underneath you assert the following.

does not report if the function has more than 3 arguments and it's defined in java

What system behavior can the user of this rule expect in the mentioned case?

[BraisGabin]

Here you check for the parameter list size to be bigger than 2, but in the test case underneath you assert the following.

does not report if the function has more than 3 arguments and it's defined in java

I fixed the description of the test to:

does not report if the function has 3 or more arguments and it's defined in java

What system behavior can the user of this rule expect in the mentioned case?

(I'm not sure if I understood what you are asking) The idea is to ignore the cases where the a function set is called and if it is defined in java and java 3 or more arguments. The full context is in the linked issue.

[schalkms]

I'm referring to the logical and numerical difference between the two statements.

code:  args > 2
test:  args > 3

Thanks for fixing the test. However, I think the code snippet in the test should then have exactly 3 parameters to assert the boundary (e.g. 3).
Excuse me for being a bit picky here.

[BraisGabin]

Done.