Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formulate rule/performance descriptions consistently #4411

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

schalkms
Copy link
Member

reference #4384

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #4411 (a82c5c7) into main (48a28fc) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4411      +/-   ##
============================================
+ Coverage     84.23%   84.28%   +0.04%     
- Complexity     3259     3282      +23     
============================================
  Files           474      474              
  Lines         10323    10429     +106     
  Branches       1825     1861      +36     
============================================
+ Hits           8696     8790      +94     
- Misses          666      670       +4     
- Partials        961      969       +8     
Impacted Files Coverage Δ
...urbosch/detekt/rules/performance/ArrayPrimitive.kt 75.00% <100.00%> (ø)
...s/performance/UnnecessaryTemporaryInstantiation.kt 84.61% <100.00%> (ø)
.../gitlab/arturbosch/detekt/rules/empty/EmptyRule.kt 92.30% <0.00%> (-3.15%) ⬇️
...etekt/rules/style/optional/MandatoryBracesLoops.kt 73.33% <0.00%> (-2.53%) ⬇️
...ab/arturbosch/detekt/core/config/ValidateConfig.kt 98.64% <0.00%> (-1.36%) ⬇️
...n/kotlin/io/gitlab/arturbosch/detekt/api/Entity.kt 75.00% <0.00%> (-1.20%) ⬇️
.../gitlab/arturbosch/detekt/api/internal/Versions.kt 87.50% <0.00%> (ø)
...n/io/github/detekt/report/html/HtmlOutputReport.kt 95.55% <0.00%> (ø)
.../arturbosch/detekt/generator/out/AbstractWriter.kt 0.00% <0.00%> (ø)
...rturbosch/detekt/rules/style/StyleGuideProvider.kt 100.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a28fc...a82c5c7. Read the comment docs.

Copy link
Member

@chao2zhang chao2zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌷

@schalkms schalkms added this to the 1.20.0 milestone Dec 28, 2021
@schalkms schalkms merged commit 16b8920 into main Dec 28, 2021
@schalkms schalkms deleted the #4384-performance branch December 28, 2021 01:14
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants