Don't exclude the naming rules by default for tests#4438
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4438 +/- ##
============================================
- Coverage 84.32% 84.32% -0.01%
Complexity 3293 3293
============================================
Files 472 472
Lines 10522 10521 -1
Branches 1885 1885
============================================
- Hits 8873 8872 -1
Misses 671 671
Partials 978 978
Continue to review full report at Codecov.
|
schalkms
approved these changes
Jan 2, 2022
cortinico
approved these changes
Jan 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, the rules that apply to good naming patterns in production code can be applied for the test code too. The only exception are the function names. And to be honest that's mainly because of JUnit but I don't want to cross that bridge yet. So this PR remove the excludes for all the rules except
FunctionNaming.I also changed our (not the default one) value for
TopLevelPropertyNaming.constantPattern:. Otherwise I would need to do this changes like this that I think that are way worst:describe("QualifiedNameProcessor") { it("fqNamesOfTestFiles") { - val ktFile = compileContentForTest(code) + val ktFile = compileContentForTest(CODE) val processor = QualifiedNameProcessor() processor.onProcess(ktFile, BindingContext.EMPTY) processor.onFinish(listOf(ktFile), result, BindingContext.EMPTY) @@ -54,7 +54,7 @@ private val result = object : Detektion { } } -private const val code = """ +private const val CODE = """ package io.gitlab.arturbosch.detekt.sample class Foo {}closes #4144