[FunctionNaming] Don't allow the usage of ` in function names#4439
Merged
Conversation
a1181a2 to
eac3708
Compare
eac3708 to
9eeff76
Compare
Codecov Report
@@ Coverage Diff @@
## main #4439 +/- ##
=========================================
Coverage 84.32% 84.32%
Complexity 3293 3293
=========================================
Files 472 472
Lines 10522 10522
Branches 1885 1885
=========================================
Hits 8873 8873
Misses 671 671
Partials 978 978
Continue to review full report at Codecov.
|
schalkms
approved these changes
Jan 2, 2022
picklebento
approved these changes
Jan 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the Kotlin Coding conventions:
https://kotlinlang.org/docs/coding-conventions.html#names-for-test-methods
And we are excluding this rule from test source sets so there is not point to alow it. It just allow false-negatives in production code.