Add option for OutdatedDocumentation to allow param in constructor pr…#4453
Merged
cortinico merged 1 commit intodetekt:mainfrom Jan 7, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4453 +/- ##
============================================
+ Coverage 84.34% 84.35% +0.01%
- Complexity 3299 3306 +7
============================================
Files 473 473
Lines 10532 10541 +9
Branches 1885 1888 +3
============================================
+ Hits 8883 8892 +9
Misses 671 671
Partials 978 978
Continue to review full report at Codecov.
|
9f92973 to
3a2825c
Compare
marschwar
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4366
Ideally, all constructor parameters should be marked as
@property(since they are properties), but currently IntelliJ does not display parameter docs for these: https://youtrack.jetbrains.com/issue/KTIJ-12948as a workaround until this is fixed on Jetbrains side, we add a property to the OutdatedDocumentation that allows
@paramon constructor properties.