Code cleanups#4542
Merged
Merged
Conversation
cortinico
approved these changes
Jan 30, 2022
Member
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Overall looks good 👍 Just a minor nit
| } | ||
|
|
||
| fun javaExit() { | ||
| @Suppress("ReplaceJavaStaticMethodWithKotlinAnalog") |
Member
There was a problem hiding this comment.
nit: Why this? Was it triggering a warning of any form? If so where?
Contributor
Author
There was a problem hiding this comment.
As I see a suggestion by IDEA to replace System.exit(1) with exitProcess(1), it's not proper right here?
Member
There was a problem hiding this comment.
it's not proper right here?
I think it's ok. This is a test resource, so we're not actually executing it and should be treated as plain-text. However, as the IDE is recognizing that is Kotlin code, it's probably ok to have it.
schalkms
approved these changes
Jan 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sortin kotlin.Untilin kotlin.