Deprecate continuationIndentSize from the Indentation rule #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, I wasn't aware of it. A quick workaround would be to add a line here: https://github.com/detekt/detekt/blob/main/detekt-core/src/main/resources/deprecation.properties. We could hardcode it in our Then, if we want to provide this option to any developer, we can open an issue and work on a proper solution. It shouldn't be too difficult but I vote to don't do this until a user ask for it. |
BraisGabin
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should not use the
continuationIndentSizeas it's essentially ignored by KtLint. Sadly we don't have a way to deprecate properties from rules insideformatting(cc @BraisGabin, were you aware of it? Should we offer this capacity?)Fixes #2970