Drop Groovy DSL testing in DetektTaskDslSpec#4563
Merged
3flex merged 2 commits intodetekt:mainfrom Feb 7, 2022
Merged
Conversation
BraisGabin
approved these changes
Feb 7, 2022
This was referenced Feb 7, 2022
Goooler
pushed a commit
to Goooler/detekt
that referenced
this pull request
Feb 10, 2022
* Drop Groovy DSL testing in DetektTaskDslSpec * Reformat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4560
Because I'm partway through migrating detekt-gradle-plugin tests to JUnit, it's easier for me to update this file first, then finish the JUnit migration for this project, then drop Groovy DSL tests in the remaining files.
First commit is the functional change without modifying whitespace, the second is just a reformat of the file to make it easier to review.