Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeep Gradle scripts #4589

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Housekeep Gradle scripts #4589

merged 2 commits into from
Feb 21, 2022

Conversation

chao2zhang
Copy link
Member

@chao2zhang chao2zhang commented Feb 19, 2022

  • Move our own Gradle scripts to the new reporting configuration API.
  • Use Constants defined in DetektExtension

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #4589 (e5385b7) into main (f15ce50) will increase coverage by 84.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4589       +/-   ##
===========================================
+ Coverage        0   84.49%   +84.49%     
- Complexity      0     3335     +3335     
===========================================
  Files           0      481      +481     
  Lines           0    11147    +11147     
  Branches        0     2040     +2040     
===========================================
+ Hits            0     9419     +9419     
- Misses          0      697      +697     
- Partials        0     1031     +1031     
Impacted Files Coverage Δ
...itlab/arturbosch/detekt/api/FileProcessListener.kt 100.00% <0.00%> (ø)
...ab/arturbosch/detekt/rules/bugs/ExitOutsideMain.kt 71.42% <0.00%> (ø)
...ab/arturbosch/detekt/cli/runners/ConfigExporter.kt 88.88% <0.00%> (ø)
...tekt/rules/exceptions/NotImplementedDeclaration.kt 75.00% <0.00%> (ø)
.../io/gitlab/arturbosch/detekt/rules/GuardClauses.kt 20.00% <0.00%> (ø)
.../arturbosch/detekt/rules/style/UseIsNullOrEmpty.kt 55.84% <0.00%> (ø)
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100.00% <0.00%> (ø)
...bosch/detekt/rules/exceptions/ReturnFromFinally.kt 85.71% <0.00%> (ø)
...io/github/detekt/tooling/internal/PluginsHolder.kt 100.00% <0.00%> (ø)
...detekt/rules/exceptions/ThrowingExceptionInMain.kt 90.90% <0.00%> (ø)
... and 471 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f15ce50...e5385b7. Read the comment docs.

@3flex
Copy link
Member

3flex commented Feb 20, 2022

Concatenate all include statements into one.

Can we not do this please? It makes it a bit more annoying to tweak the settings script when using Gradle's composite build feature, where you need to change include directives to includeBuild and back for example.

Unless there's some advantage to doing this I'm not aware of?

@chao2zhang
Copy link
Member Author

The only advantage is the visual appearance - I have reverted the change.

@3flex 3flex merged commit 6c3c28d into detekt:main Feb 21, 2022
@chao2zhang chao2zhang deleted the gradleclean branch February 21, 2022 17:08
@cortinico cortinico added this to the 1.20.0 milestone Feb 22, 2022
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants