Bump KtLint to 0.44.0 and add UnnecessaryParenthesesBeforeTrailingLamda rule

[kvn-stgl]

See https://github.com/pinterest/ktlint/releases/tag/0.44.0 for the full release note. I've also wrapped the new experimental UnnecessaryParenthesesBeforeTrailingLamda rule.

I also tried to implement the new VisitorModifier instead of the deprecated Rule.Modifier interfaces.

This should also fix the issue #4604

Sadly I get a lot of Unexpected indent of multiline string closing quotes [Indentation]-errors for the Unit-Tests. Maybe someone has some ideas how I can fix it.

[codecov]

Codecov Report

Merging #4630 (6ca5949) into main (8bb4c85) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #4630   +/-   ##
=========================================
  Coverage     84.52%   84.53%           
- Complexity     3358     3364    +6     
=========================================
  Files           481      482    +1     
  Lines         11193    11200    +7     
  Branches       2042     2043    +1     
=========================================
+ Hits           9461     9468    +7     
  Misses          698      698           
  Partials       1034     1034           

Impacted Files	Coverage Δ
...b/arturbosch/detekt/rules/style/ForbiddenImport.kt	95.45% <ø> (ø)
...ekt/rules/style/RedundantVisibilityModifierRule.kt	98.24% <ø> (ø)
...lab/arturbosch/detekt/formatting/FormattingRule.kt	98.07% <100.00%> (+0.16%)	⬆️
...ab/arturbosch/detekt/formatting/KtLintMultiRule.kt	95.94% <100.00%> (+0.05%)	⬆️
...etekt/formatting/wrappers/ParameterListWrapping.kt	100.00% <100.00%> (ø)
...pers/UnnecessaryParenthesesBeforeTrailingLambda.kt	100.00% <100.00%> (ø)
...n/kotlin/io/github/detekt/report/html/HtmlUtils.kt	98.33% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb4c85...6ca5949. Read the comment docs.

[cortinico]

Thanks for doing this @kvn-stgl, this is great!

I actually also had a branch with some of this work. I believe you should be able to integrate some of it in your PR (I would like to merge yours instead of mine as this looks like an amazing first-time contribution):

2a9b602

[cortinico]

This should be deprecated instead

[kvn-stgl]

Thanks @cortinico ! So you simply fixed the issues (or let the formatter do the work) .. Well, okay 😄

Can you just tell me a simple question about your changes: You wrote the following snippet: 2a9b602#diff-9cf77f9ffcbf036bf5044d1ef99728b56aad97854246f3473f69d54b4b929380R82-R86 . Is it really necessary to check the KtLint.EDITOR_CONFIG_USER_DATA_KEY? I'm not sure about it, it worked for already without it. But of course I will implement it if it is necessary.

[cortinico]

Is it really necessary to check the KtLint.EDITOR_CONFIG_USER_DATA_KEY? I'm not sure about it, it worked for already without it.

I think it is. I tried to publish a new version of the Gradle plugin locally and KtLint was crashing while executing the Indentation rule for that. That's why I had to do this change.

That's the same reason why I had to touch the detekt-formatting gradle file to include the extra dependencies KtLint 0.44.0 carries over.

[kvn-stgl]

That's the same reason why I had to touch the detekt-formatting gradle file to include the extra dependencies KtLint 0.44.0 carries over.

I was already wondering why you implemented the microutils logging framework. But now I see (and my code build locally). Thanks!

[cortinico]

Duplicated?

[kvn-stgl]

Fuuuu

[BraisGabin]

😂 We just merged 0.44 but 0.45 is out

[BraisGabin]

Oh! and thank you very much for the PR @kvn-stgl :)