Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency issue when creating PomModel (#4609) #4631

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

davidburstrom
Copy link
Contributor

Fixes #4609

@davidburstrom
Copy link
Contributor Author

I should mention that I endeavoured to create a test as well, but inherently, it'd slow down the test suite as it's not possible to deterministically trigger the issue without setting sync points in the production code.

@davidburstrom
Copy link
Contributor Author

Thanks for the approval! Who can merge?

@BraisGabin
Copy link
Member

I want to give a bit of time to other maintainers to review. Otherwise in one or two days I'll merge it :)

@BraisGabin BraisGabin merged commit 5325fd0 into detekt:main Mar 18, 2022
@cortinico cortinico added this to the 1.20.0 milestone Mar 19, 2022
davidburstromspotify added a commit to davidburstromspotify/detekt that referenced this pull request Apr 4, 2022
davidburstromspotify pushed a commit to davidburstromspotify/detekt that referenced this pull request Apr 4, 2022
davidburstromspotify pushed a commit to davidburstromspotify/detekt that referenced this pull request Apr 9, 2022
davidburstromspotify pushed a commit to davidburstromspotify/detekt that referenced this pull request Apr 9, 2022
davidburstromspotify pushed a commit to davidburstromspotify/detekt that referenced this pull request Apr 9, 2022
davidburstromspotify pushed a commit to davidburstromspotify/detekt that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel invocation of AnalysisFacade fails spuriously in 1.20.0-RC1
5 participants