Display dynamic --jvm-target values when using --help flag#4694
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4694 +/- ##
============================================
- Coverage 84.45% 84.44% -0.02%
Complexity 3436 3436
============================================
Files 492 492
Lines 11335 11337 +2
Branches 2082 2083 +1
============================================
Hits 9573 9573
- Misses 701 703 +2
Partials 1061 1061
Continue to review full report at Codecov.
|
This will now print values supported by the embedded Kotlin version and won't have to be updated manually anymore.
BraisGabin
approved these changes
Apr 7, 2022
cortinico
approved these changes
Apr 7, 2022
picklebento
pushed a commit
that referenced
this pull request
Apr 8, 2022
3flex
added a commit
to 3flex/detekt
that referenced
this pull request
May 7, 2022
…etekt#4694)" This reverts commit 7c903c5.
cortinico
pushed a commit
that referenced
this pull request
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will now print values supported by the embedded Kotlin version and won't have to be updated manually anymore.
The required toString override was introduced in Kotlin 1.6.20 thanks to my first PR on jetbrains/kotlin :)
Before:
After: