Skip to content

Update the argsfile to unblock runWithArgsFile failing locally#4718

Merged
schalkms merged 1 commit intomainfrom
nc/runWithArgsFile
Apr 16, 2022
Merged

Update the argsfile to unblock runWithArgsFile failing locally#4718
schalkms merged 1 commit intomainfrom
nc/runWithArgsFile

Conversation

@cortinico
Copy link
Copy Markdown
Member

I had several failures of runWithArgsFile locally due to files in the build-login/bin folder. I'm excluding it from the args file.

@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Apr 14, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2022

Codecov Report

Merging #4718 (89857f0) into main (583ab1e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4718   +/-   ##
=========================================
  Coverage     84.71%   84.71%           
  Complexity     3423     3423           
=========================================
  Files           490      490           
  Lines         11255    11255           
  Branches       2069     2069           
=========================================
  Hits           9535     9535           
  Misses          675      675           
  Partials       1045     1045           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 583ab1e...89857f0. Read the comment docs.

@schalkms schalkms merged commit 69772a7 into main Apr 16, 2022
@schalkms schalkms deleted the nc/runWithArgsFile branch April 16, 2022 19:29
@cortinico cortinico added this to the 1.21.0 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants