Break a dependency between detekt-gradle-plugin and detekt-utils#4748
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4748 +/- ##
=========================================
Coverage 84.69% 84.69%
Complexity 3418 3418
=========================================
Files 490 490
Lines 11235 11235
Branches 2068 2068
=========================================
Hits 9516 9516
Misses 675 675
Partials 1044 1044 Continue to review full report at Codecov.
|
picklebento
approved these changes
Apr 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm removing a dependency between
detekt-gradle-pluginanddetekt-utils. This is making harder to move to a composite build + it's an unnecessary dependency as we just use a function from detekt-utils.This also causes build failures for users if
detekt-gradle-pluginis published anddetekt-utilsis not yet. See #4696 (comment)