Skip to content

Break a dependency between detekt-gradle-plugin and detekt-utils#4748

Merged
cortinico merged 1 commit into
mainfrom
nc/gradle-plugin-should-not-depend-on-util
Apr 23, 2022
Merged

Break a dependency between detekt-gradle-plugin and detekt-utils#4748
cortinico merged 1 commit into
mainfrom
nc/gradle-plugin-should-not-depend-on-util

Conversation

@cortinico
Copy link
Copy Markdown
Member

I'm removing a dependency between detekt-gradle-plugin and detekt-utils. This is making harder to move to a composite build + it's an unnecessary dependency as we just use a function from detekt-utils.

This also causes build failures for users if detekt-gradle-plugin is published and detekt-utils is not yet. See #4696 (comment)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2022

Codecov Report

Merging #4748 (2f0cc96) into main (7960453) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4748   +/-   ##
=========================================
  Coverage     84.69%   84.69%           
  Complexity     3418     3418           
=========================================
  Files           490      490           
  Lines         11235    11235           
  Branches       2068     2068           
=========================================
  Hits           9516     9516           
  Misses          675      675           
  Partials       1044     1044           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7960453...2f0cc96. Read the comment docs.

@cortinico cortinico merged commit d021c60 into main Apr 23, 2022
@cortinico cortinico deleted the nc/gradle-plugin-should-not-depend-on-util branch April 23, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants