Move detekt-gradle-plugin to be a composite build

[cortinico]

Stacked on top of #4748

This converts our project to use Gradle Composite builds.
With this we won't need to depend on external, previously published versions of detekt-gradle-plugin. It will help us prevent and catch earlier a lot of bugs we discover during the release process.

I've also introduced a buildAll top level task that builds everything (all the subprojects and run the build task on the included build).

I've removed the applySelfAnalysisVersion task as that's unnecessary now.

[codecov]

Codecov Report

Merging #4751 (c094263) into main (17a62ec) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4751   +/-   ##
=========================================
  Coverage     84.69%   84.69%           
  Complexity     3413     3413           
=========================================
  Files           490      490           
  Lines         11232    11232           
  Branches       2065     2065           
=========================================
  Hits           9513     9513           
  Misses          675      675           
  Partials       1044     1044           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a62ec...c094263. Read the comment docs.

[cortinico]

I'd like to hear @3flex opinion on this before we merge it 👍

[3flex]

Looks good, there may be a few teething issues but I think this is a win overall!

[3flex]

This needs to stay, there's no equivalent config anywhere else in the project to add src/functionalTest to the source checked by the detekt task.

[cortinico]

Sadly, this can't stay. The detekt-gradle-plugin build can't use itself.

We would have to use again an older published version of the detekt-gradle-plugin which I would like to avoid frankly (as it's the problem we're trying to address here.

I would rather rely on the runWithArgsFile as it should handle also the src/functionalTest/kotlin folder.

[chao2zhang]

runWithArgsFile checks the entire codebase, so it should cover all sources under src/functionalTest

[3flex]

The reason I added this block to this build file is running :detekt-gradle-plugin:build doesn't check functionalTest sources without it, because none of the configured Gradle detekt tasks in detekt-gradle-plugin checked it, so CI would fail when I pushed and runWithArgsFile ran, and it became quite frustrating. Running runWithArgsFile locally is just another thing to remember to do before pushing, and it's poor DX.

detekt-gradle-plugin build can't use itself.

True, but we can add id("io.gitlab.arturbosch.detekt") version "1.20.0" to the plugins block in detekt-gradle-plugin. I assume renovate will notify about updates, and updating that version still won't be tied to the release process.

[cortinico]

I see, thanks for clarifying. I think it's ok to include the id("io.gitlab.arturbosch.detekt") version "1.20.0" and don't bump it as part of the release process (let's renovate do the job as you suggested).

[cortinico]

Are you fine with me adding this in a separate PR?

[3flex]

Are you fine with me adding this in a separate PR?

Yep, LGTM!

[chao2zhang]

This change may impact the Gradle Enterprise trial progress. As we found that functionalTest does not conform to the incremental buil.
https://ge.detekt.dev/s/vue3arlrp3gvw/timeline?anchor=5cf5p64octxus

Let's merge this in as soon as we can.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
detekt	✅ Ready (Inspect)	Visit Preview	Apr 24, 2022 at 9:35PM (UTC)