-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Gradle Plugin Publications #4752
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4752 +/- ##
=========================================
Coverage 84.70% 84.70%
Complexity 3426 3426
=========================================
Files 491 491
Lines 11253 11253
Branches 2069 2069
=========================================
Hits 9532 9532
Misses 676 676
Partials 1045 1045 Continue to review full report at Codecov.
|
4d65617
to
446b2dd
Compare
build.gradle.kts
Outdated
} | ||
} | ||
dependsOn(gradle.includedBuild("detekt-gradle-plugin").task(":publishAllPublicationsToMavenCentralRepository")) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these tasks could go into releasing.gradle.kts
to keep the root project file tidy (and because these tasks are all about releasing/publishing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And maybe expand the current task instead of creating a new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved.
expand the current task
There are no publishing tasks registered on the top level project. So they all need to be created. I've updated the publishToMavenLocal
one, as that might be used by contributors. For the other 2, I've used shorter version as they're easier to understand
build.gradle.kts
Outdated
} | ||
} | ||
dependsOn(gradle.includedBuild("detekt-gradle-plugin").task(":publishAllPublicationsToMavenCentralRepository")) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And maybe expand the current task instead of creating a new one?
446b2dd
to
648014a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
881a353
to
0d82ff2
Compare
648014a
to
d1dbf6b
Compare
Stacked on top of #4751
I've removed the
isAutomatedPublishing
hack we had for the Gradle Plugin.This means that we'll rely on the publishing configured by the Gradle Publishing plugin (We might want to configure the POM though).
The side effect of this, is that now we'll have both the Gradle Plugin and the Gradle Plugin marker published, either on Maven Local or Central.
This will simplify local development + will allow users to depend on the plugin from Central only.
I've also added several top level tasks to help facilitate this process.