Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Gradle Plugin Publications #4752

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Conversation

cortinico
Copy link
Member

@cortinico cortinico commented Apr 23, 2022

Stacked on top of #4751

I've removed the isAutomatedPublishing hack we had for the Gradle Plugin.
This means that we'll rely on the publishing configured by the Gradle Publishing plugin (We might want to configure the POM though).

The side effect of this, is that now we'll have both the Gradle Plugin and the Gradle Plugin marker published, either on Maven Local or Central.

This will simplify local development + will allow users to depend on the plugin from Central only.

I've also added several top level tasks to help facilitate this process.

@cortinico cortinico added this to the 1.21.0 milestone Apr 23, 2022
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #4752 (d1dbf6b) into main (a2734b1) will not change coverage.
The diff coverage is n/a.

❗ Current head d1dbf6b differs from pull request most recent head 1ae7ba2. Consider uploading reports for the commit 1ae7ba2 to get more accurate results

@@            Coverage Diff            @@
##               main    #4752   +/-   ##
=========================================
  Coverage     84.70%   84.70%           
  Complexity     3426     3426           
=========================================
  Files           491      491           
  Lines         11253    11253           
  Branches       2069     2069           
=========================================
  Hits           9532     9532           
  Misses          676      676           
  Partials       1045     1045           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2734b1...1ae7ba2. Read the comment docs.

@cortinico cortinico force-pushed the nc/cleanup-gradle-plugin-publishing branch from 4d65617 to 446b2dd Compare April 23, 2022 15:25
@chao2zhang chao2zhang changed the title Cleanup Gradle Plugin Pubblications Cleanup Gradle Plugin Publications Apr 23, 2022
build.gradle.kts Outdated
}
}
dependsOn(gradle.includedBuild("detekt-gradle-plugin").task(":publishAllPublicationsToMavenCentralRepository"))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these tasks could go into releasing.gradle.kts to keep the root project file tidy (and because these tasks are all about releasing/publishing)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe expand the current task instead of creating a new one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved.

expand the current task

There are no publishing tasks registered on the top level project. So they all need to be created. I've updated the publishToMavenLocal one, as that might be used by contributors. For the other 2, I've used shorter version as they're easier to understand

build.gradle.kts Outdated
}
}
dependsOn(gradle.includedBuild("detekt-gradle-plugin").task(":publishAllPublicationsToMavenCentralRepository"))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe expand the current task instead of creating a new one?

@cortinico cortinico force-pushed the nc/cleanup-gradle-plugin-publishing branch from 446b2dd to 648014a Compare April 24, 2022 12:25
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortinico cortinico force-pushed the nc/composite-build branch from 881a353 to 0d82ff2 Compare April 24, 2022 20:07
Base automatically changed from nc/composite-build to main April 25, 2022 01:24
@cortinico cortinico merged commit dac5401 into main Apr 26, 2022
@cortinico cortinico deleted the nc/cleanup-gradle-plugin-publishing branch April 26, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants