Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-inspect the detekt-gradle-plugin #4765

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

cortinico
Copy link
Member

Here I'm setting up the self-inspection on detekt-gradle-plugin (cc @3flex).

I have to admit that I'm not extremely excited of this, as we might face problems with the config file of detekt being incompatible between the latest released version and main.

@vercel
Copy link

vercel bot commented Apr 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
detekt ✅ Ready (Inspect) Visit Preview Apr 25, 2022 at 1:38PM (UTC)

@3flex
Copy link
Member

3flex commented Apr 25, 2022

we might face problems with the config file of detekt being incompatible between the latest released version and main

Good point - now that the Gradle plugin is in its own isolated build and running a different version of detekt, this is unavoidable if the same config is used for the plugin as the rest of the project.

So I would suggest giving the Gradle plugin its own config and baseline file (though I'm not sure if there are any issues in the baseline at the moment?)

The repetition might be undesirable but I agree with what I think you're saying, that we should prioritise stability of the build.

@cortinico cortinico force-pushed the nc/self-inspect-gradle-plugin branch from 9ca5180 to 8bd1bfd Compare April 26, 2022 21:50
@github-actions github-actions bot added the ci label Apr 26, 2022
@cortinico
Copy link
Member Author

cortinico commented Apr 26, 2022

So I would suggest giving the Gradle plugin its own config and baseline file (though I'm not sure if there are any issues in the baseline at the moment?)

Yup that sounds like a good compromise. Added 👍

@cortinico cortinico merged commit 883a89e into detekt:main Apr 26, 2022
@cortinico cortinico deleted the nc/self-inspect-gradle-plugin branch April 26, 2022 23:02
@cortinico cortinico added this to the 1.21.0 milestone Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants