Skip to content

fix: add test case that fails if environment is not properly set up#4769

Merged
schalkms merged 2 commits into
detekt:mainfrom
marschwar:fix/source-set-test-case
Apr 25, 2022
Merged

fix: add test case that fails if environment is not properly set up#4769
schalkms merged 2 commits into
detekt:mainfrom
marschwar:fix/source-set-test-case

Conversation

@marschwar
Copy link
Copy Markdown
Contributor

This relatest to the comment #4575 (comment) and adds a test case that fails if the java environment is not properly set up. The original test still succeeds because the function cannot be resolved and will not issue a code smell by default.

@marschwar marschwar added the housekeeping Marker for housekeeping tasks and refactorings label Apr 25, 2022
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
detekt 🔄 Building (Inspect) Apr 25, 2022 at 7:23PM (UTC)

@github-actions github-actions Bot added the rules label Apr 25, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2022

Codecov Report

Merging #4769 (433e2b4) into main (950554c) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 433e2b4 differs from pull request most recent head 2f43759. Consider uploading reports for the commit 2f43759 to get more accurate results

@@            Coverage Diff            @@
##               main    #4769   +/-   ##
=========================================
  Coverage     84.69%   84.70%           
- Complexity     3413     3414    +1     
=========================================
  Files           490      490           
  Lines         11232    11232           
  Branches       2065     2065           
=========================================
+ Hits           9513     9514    +1     
  Misses          675      675           
+ Partials       1044     1043    -1     
Impacted Files Coverage Δ
...les/style/ExplicitCollectionElementAccessMethod.kt 66.66% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950554c...2f43759. Read the comment docs.

Copy link
Copy Markdown
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a comment or an extended test description for the reasoning behind the test.

@cortinico cortinico added this to the 1.21.0 milestone Apr 25, 2022
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/detekt/detekt/61FQmRyYU1gxdQSKUS2tan3NYghL
✅ Preview: https://detekt-git-fork-marschwar-fix-source-set-test-case-detekt.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants