Allow additionalJavaSourceRootPaths to be defined on @KotlinCoreEnvironmentTest #4771
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #4771 +/- ##
=========================================
Coverage 84.80% 84.80%
Complexity 3453 3453
=========================================
Files 492 492
Lines 11328 11328
Branches 2086 2086
=========================================
Hits 9607 9607
Misses 673 673
Partials 1048 1048 Continue to review full report at Codecov.
|
…a-source # Conflicts: # detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/ExplicitCollectionElementAccessMethodSpec.kt # detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/ObjectLiteralToLambdaSpec.kt
There was a problem hiding this comment.
This PR shows the need of #4705 (and nearly all our tests). We have a lot of multiline strings and I don't even know how should we indent them "properly".
|
I don't think I understand that comment. I introduced and additional level of nesting and that changes the indentation. I do not see this as evidence that we need the multi-line string rule - even though it might still be a good rule to have. |
You are adding indentation to your code, but if you see that code inside the multiline didn't change its indentation. The code inside the multiline string has less indentation that the opening multiline operator |
|
Ok, I get it now. Is there a correct way to indent multi line strings? |
|
I assume that there should be. But I don't know which it is. To me, the important part is to be consistent. |
|
@marschwar @BraisGabin any plans to get this ahead? |
|
From my point of view this is ready. |
|
More than 1 month with an approve and no open comments seems fair to merge to me so... |
This relates to #4575 and exposes the
additionalJavaSourceRootPathsproperty fromKotlinCoreEnvironmentWrapper.createEnvironmentasadditionalJavaSourcePathsin the KotlinCoreEnvironmentTest annotation.There are only very few instances where this feature is needed, so the list of additionalJavaSourcePaths defaults to an empty list.
Changes in the tests are mostly indentation because I introduced two top level nested classes to split into WithDefaultSources and WithAdditionalJavaSources.