Skip to content

Add dependency on slf4j-nop to silence warning#4775

Merged
3flex merged 1 commit intodetekt:mainfrom
cortinico:nc/slf4j-nop
Apr 26, 2022
Merged

Add dependency on slf4j-nop to silence warning#4775
3flex merged 1 commit intodetekt:mainfrom
cortinico:nc/slf4j-nop

Conversation

@cortinico
Copy link
Copy Markdown
Member

Fixes #4679

See https://ge.detekt.dev/s/lotfhvt2gspyq for a run without the SLF4J warning.

@cortinico cortinico added this to the 1.21.0 milestone Apr 25, 2022
@github-actions github-actions bot added build dependencies Pull requests that update a dependency file labels Apr 25, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 25, 2022

Codecov Report

Merging #4775 (fd2860b) into main (a2734b1) will not change coverage.
The diff coverage is n/a.

❗ Current head fd2860b differs from pull request most recent head 8f0287e. Consider uploading reports for the commit 8f0287e to get more accurate results

@@            Coverage Diff            @@
##               main    #4775   +/-   ##
=========================================
  Coverage     84.70%   84.70%           
  Complexity     3426     3426           
=========================================
  Files           491      491           
  Lines         11253    11253           
  Branches       2069     2069           
=========================================
  Hits           9532     9532           
  Misses          676      676           
  Partials       1045     1045           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2734b1...8f0287e. Read the comment docs.

@cortinico
Copy link
Copy Markdown
Member Author

cortinico commented Apr 25, 2022

And this won't work :/ We might need to use the shadow plugin for the formatting jar.

Solved using runtimeOnly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SLF4J warning getting printed when running Detekt 1.20.0-RC2

3 participants