Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report as warnings the Strings that should be an array #4793

Merged
merged 2 commits into from May 12, 2022
Merged

Conversation

BraisGabin
Copy link
Collaborator

@BraisGabin BraisGabin commented Apr 30, 2022

With this we will show to our users a warning when they are using a comma-separeted String instead of a yaml array. This way, some release later, we can drop the support to the comma-separated String.

Fix #4498

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #4793 (b0a6312) into main (22bc63d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #4793   +/-   ##
=========================================
  Coverage     84.70%   84.71%           
  Complexity     3426     3426           
=========================================
  Files           491      491           
  Lines         11253    11259    +6     
  Branches       2069     2071    +2     
=========================================
+ Hits           9532     9538    +6     
  Misses          676      676           
  Partials       1045     1045           
Impacted Files Coverage Δ
...ab/arturbosch/detekt/core/config/ValidateConfig.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22bc63d...b0a6312. Read the comment docs.

@cortinico cortinico added the notable changes Marker for notable changes in the changelog label Apr 30, 2022
@cortinico cortinico added this to the 1.21.0 milestone Apr 30, 2022
…onfig/ValidateConfig.kt

Co-authored-by: Nicola Corti <corti.nico@gmail.com>
@BraisGabin BraisGabin merged commit 045928b into main May 12, 2022
20 checks passed
@BraisGabin BraisGabin deleted the fix-4498 branch May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core notable changes Marker for notable changes in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants