Report as warnings the Strings that should be an array#4793
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4793 +/- ##
=========================================
Coverage 84.70% 84.71%
Complexity 3426 3426
=========================================
Files 491 491
Lines 11253 11259 +6
Branches 2069 2071 +2
=========================================
+ Hits 9532 9538 +6
Misses 676 676
Partials 1045 1045
Continue to review full report at Codecov.
|
cortinico
reviewed
Apr 30, 2022
…onfig/ValidateConfig.kt Co-authored-by: Nicola Corti <corti.nico@gmail.com>
cortinico
approved these changes
May 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this we will show to our users a warning when they are using a comma-separeted String instead of a yaml array. This way, some release later, we can drop the support to the comma-separated String.
Fix #4498