Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4801 +/- ##
============================================
+ Coverage 84.70% 84.72% +0.01%
Complexity 3426 3426
============================================
Files 491 491
Lines 11253 11257 +4
Branches 2069 2069
============================================
+ Hits 9532 9537 +5
+ Misses 676 674 -2
- Partials 1045 1046 +1
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
May 3, 2022
Member
BraisGabin
left a comment
There was a problem hiding this comment.
Shouldn't we test the improved error messages?
Member
Author
|
We don't test the old ones :P Feel free to do it in a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests added to show that correctly formatted strings provided on the CLI are parsed as expected, and that the Gradle plugin maps the
jvmTargetandlanguageVersionproperties to those CLI flags as expected.I've also improved the error message provided by the CLI when these flags cannot be parsed which should help narrow down issues.