Fix ValShouldBeVar false positive inside unknown type#4820
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4820 +/- ##
============================================
+ Coverage 84.71% 84.74% +0.03%
Complexity 3431 3431
============================================
Files 491 491
Lines 11267 11270 +3
Branches 2075 2074 -1
============================================
+ Hits 9545 9551 +6
Misses 673 673
+ Partials 1049 1046 -3
Continue to review full report at Codecov.
|
schalkms
approved these changes
May 8, 2022
BraisGabin
approved these changes
May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at fixing false positives for ValShouldBeVar when the assignment is inside an unknown type. This is the only logical solution I can think of at the moment. It basically assumes that if we can't resolve the type of the assignment, then it is from the inside of an unknown context (like a with-statement). Let me know if there is something I'm missing, and we can close/reject this PR...
Fixes #4736