-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Markdown report #4858
Add Markdown report #4858
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4858 +/- ##
============================================
+ Coverage 84.83% 84.95% +0.11%
- Complexity 3511 3520 +9
============================================
Files 497 498 +1
Lines 11548 11642 +94
Branches 2138 2146 +8
============================================
+ Hits 9797 9890 +93
+ Misses 686 685 -1
- Partials 1065 1067 +2
Continue to review full report at Codecov.
|
detekt-report-md/src/main/kotlin/io/github/detekt/report/md/MdOutputReport.kt
Outdated
Show resolved
Hide resolved
detekt-report-md/src/main/kotlin/io/github/detekt/report/md/MdUtils.kt
Outdated
Show resolved
Hide resolved
I like it! I have a suggestion: # detekt
## Metrics
...
## Complexity
...
## Findings ($total)
### Rule1 ($total)
- Finding1.1
- Finding1.2
### Rule2 ($total)
- Finding2.1
- Finding2.2 What do you thinkg? Basically the change is to use a header for each rule instead of adding it in a list. |
Why not! It would be more compact, I'll fix that. |
Use headings instead of list for 'Rules' section
Move Markdown.kt, Yaml.kt and YamlSpec.kt from 'detekt-generator' to 'detekt-tooling' package. Refactor 'detekt-generator' and 'detekt-report-md' so that they depend on 'detekt-tooling'.
Co-authored-by: Brais Gabín <braisgabin@gmail.com>
# Conflicts: # detekt-generator/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/defaultconfig/RuleSetConfigPrinter.kt # detekt-tooling/src/main/kotlin/io/github/detekt/tooling/out/Yaml.kt
It seems that it is failing on windows. |
Yep. But I really don't know why, there's no OS specific code in the PR. |
For #4826 (Add a Markdown report format)
The report is similar to HTML report and looks like this:
detekt
Metrics
Complexity Report
Findings (3)
Section-1, id_a (2)
Description id_a
Documentation
Section-2, id_b (1)
Description id_b
Documentation
generated with detekt version 1.20.0 on 2022-05-25 14:25:27 UTC