Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnnecessaryInnerClass: fix false negative with this references #4884

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

t-kameyama
Copy link
Contributor

Fixes #4866

@github-actions github-actions bot added the rules label Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #4884 (05419b1) into main (f66a321) will decrease coverage by 0.03%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##               main    #4884      +/-   ##
============================================
- Coverage     84.81%   84.78%   -0.04%     
+ Complexity     3463     3462       -1     
============================================
  Files           493      493              
  Lines         11357    11354       -3     
  Branches       2090     2093       +3     
============================================
- Hits           9632     9626       -6     
  Misses          675      675              
- Partials       1050     1053       +3     
Impacted Files Coverage Δ
...rbosch/detekt/rules/style/UnnecessaryInnerClass.kt 85.18% <60.00%> (-6.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f66a321...05419b1. Read the comment docs.

@cortinico cortinico added this to the 1.21.0 milestone Jun 1, 2022
@BraisGabin BraisGabin merged commit 05cd796 into detekt:main Jun 1, 2022
@t-kameyama t-kameyama deleted the issue_4866 branch June 1, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on UnnecessaryInnerClass calls to this
3 participants