CastToNullableType: allow casting null keyword #4907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a false positive for CastToNullableType for casting a literal `null` to a nullable type. This can be necessary when providing null as a function argument where the incoming type is parameterized. In this case using e.g. `null as? String` is less meaningful and generates a compiler warning that the cast cannot succeed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/CastToNullableType.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## main #4907 +/- ##
=========================================
Coverage 84.83% 84.83%
- Complexity 3511 3512 +1
=========================================
Files 497 497
Lines 11548 11549 +1
Branches 2138 2139 +1
=========================================
+ Hits 9797 9798 +1
Misses 686 686
Partials 1065 1065
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Jun 4, 2022
schalkms
approved these changes
Jun 4, 2022
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a false positive for CastToNullableType for casting a literal
nullto a nullable type. This can be necessary when providing null as a function argument where the incoming type is parameterized. In this case using e.g.null as? Stringis less meaningful and generates a compiler warning that the cast cannot succeed.