Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum supported Gradle version to 6.7.1 #4964

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

3flex
Copy link
Member

@3flex 3flex commented Jun 17, 2022

Aligns to Kotlin 1.7.0, and allows us to support Java Toolchains.

@cortinico cortinico added the notable changes Marker for notable changes in the changelog label Jun 17, 2022
@3flex
Copy link
Member Author

3flex commented Jun 17, 2022

Off topic - do we need both a milestone AND the blocked tag?

I think of blockers as being something external that prevents merging for some reason, but this PR isn't blocked by anything, we're just making the choice not to merge it yet, and the milestone has been set appropriately.

@cortinico
Copy link
Member

Off topic - do we need both a milestone AND the blocked tag?

Nope not necessarily. But the blocked tag is red and has a better visual cue and is harder to miss. Milestones instead can be confused easily as it's just a matter of a character.

@3flex
Copy link
Member Author

3flex commented Jun 17, 2022

Maybe we should have a separate "don't merge yet" or "queued for next release" tag (or something like it)?

@cortinico
Copy link
Member

Maybe we should have a separate "don't merge yet" or "queued for next release" tag (or something like it)?

I'm fine either way 👍

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #4964 (324f050) into main (4015679) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4964   +/-   ##
=========================================
  Coverage     84.92%   84.92%           
  Complexity     3605     3605           
=========================================
  Files           502      502           
  Lines         11873    11873           
  Branches       2227     2227           
=========================================
  Hits          10083    10083           
  Misses          691      691           
  Partials       1099     1099           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4015679...324f050. Read the comment docs.

@chao2zhang chao2zhang merged commit 412ff11 into detekt:main Jul 19, 2022
@3flex 3flex deleted the min-gradle branch July 19, 2022 02:18
VitalyVPinchuk pushed a commit to VitalyVPinchuk/detekt that referenced this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation gradle-plugin notable changes Marker for notable changes in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants