Skip to content

Fix ReturnCount debt and refactor code#5026

Merged
schalkms merged 3 commits intodetekt:mainfrom
amitd291:fix-return-count-debt
Jul 1, 2022
Merged

Fix ReturnCount debt and refactor code#5026
schalkms merged 3 commits intodetekt:mainfrom
amitd291:fix-return-count-debt

Conversation

@amitd291
Copy link
Copy Markdown
Contributor

@amitd291 amitd291 commented Jul 1, 2022

This PR achieves the following:

  1. Fix ReturnCount debt in UnnecessaryBackticks
  2. Remove code duplication in NullableBooleanCheck

@github-actions github-actions bot added the rules label Jul 1, 2022
@schalkms schalkms merged commit ddcf77d into detekt:main Jul 1, 2022
@amitd291 amitd291 deleted the fix-return-count-debt branch July 1, 2022 20:30
Copy link
Copy Markdown
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the change in the backtick rule improves the readability.

@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Jul 5, 2022
@cortinico cortinico added this to the 1.21.0 milestone Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants