Bump ktlint to version 0.46.1 #5044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
BraisGabin
reviewed
Jul 7, 2022
| @@ -7,7 +7,8 @@ | |||
| * You need kotlin 1.3.70+ installed on your machine | |||
| */ | |||
|
|
|||
| @file:Suppress("detekt.CommentSpacing") // for the exec line | |||
| // for the exec line | |||
| @file:Suppress("detekt.CommentSpacing") | |||
There was a problem hiding this comment.
🤔 this change seems a bit odd, isn't it?
There was a problem hiding this comment.
Yes, it seems odd. I'm not sure whether we have a false positive here or not. The problem is the AnnotationOnSeparateLineRule rule from detekt: /home/runner/work/detekt/detekt/scripts/github-milestone-report.main.kts:10:1: Annotations with parameters should all be placed on separate lines prior to the annotated construct [AnnotationOnSeparateLine]
There was a problem hiding this comment.
I wrote a bug ticket at the ktlint project to fix this issue: pinterest/ktlint#1539
...io/gitlab/arturbosch/detekt/formatting/wrappers/SpacingBetweenDeclarationsWithAnnotations.kt
Outdated
Show resolved
Hide resolved
...in/io/gitlab/arturbosch/detekt/formatting/wrappers/SpacingBetweenDeclarationsWithComments.kt
Outdated
Show resolved
Hide resolved
|
Thank you for split it :) this was way way easier to review :) |
BraisGabin
approved these changes
Jul 7, 2022
VitalyVPinchuk
pushed a commit
to VitalyVPinchuk/detekt
that referenced
this pull request
Jul 25, 2022
* Bump ktlint to v0.46.1 * add NoBlankLinesInChainedMethodCalls.kt rule * set ActiveByDefault to 1.22.0 * fix various detekt issues * fix review notes * fix AnnotationOnSeparateLine in github-milestone-report.main.kts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/pinterest/ktlint/releases/tag/0.46.0 and https://github.com/pinterest/ktlint/releases/tag/0.46.1 for full release notes.
This PR is part of the ktlint upgrade to version 0.46. See #5040
It includes:
Closes #5022