Fix current indentation#5059
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
Author
|
I'm moving this to draft until #5060 is fixed. |
BraisGabin
force-pushed
the
show-raw-string-ingentation
branch
from
August 2, 2022 19:32
e525cdc to
4e0dee9
Compare
BraisGabin
marked this pull request as ready for review
August 2, 2022 19:32
Member
Author
|
This is ready for review now that #5060 is fixed. |
cortinico
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues that #5058 found on our code base. I did to ensure that the rule works properly.
If you think about it these cahnges are really few. We have way more bad formatted raw strings. The point is that the rule implemented on #5058 only flags raw-strings that call
.trimMargin()or.trimIndent()and we don't call those functions. I think that we should change that and always call.trimIndent()(#5051 will help with that). Then the rule will flag way more bad formatted raw-strings and we will be able to fix them.