Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current indentation #5059

Merged
merged 1 commit into from Aug 3, 2022
Merged

Fix current indentation #5059

merged 1 commit into from Aug 3, 2022

Conversation

BraisGabin
Copy link
Collaborator

This PR fixes the issues that #5058 found on our code base. I did to ensure that the rule works properly.

If you think about it these cahnges are really few. We have way more bad formatted raw strings. The point is that the rule implemented on #5058 only flags raw-strings that call .trimMargin() or .trimIndent() and we don't call those functions. I think that we should change that and always call .trimIndent() (#5051 will help with that). Then the rule will flag way more bad formatted raw-strings and we will be able to fix them.

@BraisGabin
Copy link
Collaborator Author

I'm moving this to draft until #5060 is fixed.

@BraisGabin BraisGabin marked this pull request as draft July 20, 2022 17:50
@BraisGabin BraisGabin removed this from the 1.22.0 milestone Jul 20, 2022
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Jul 20, 2022
@BraisGabin BraisGabin marked this pull request as ready for review August 2, 2022 19:32
@BraisGabin
Copy link
Collaborator Author

This is ready for review now that #5060 is fixed.

@BraisGabin BraisGabin merged commit 3bc81d2 into main Aug 3, 2022
19 checks passed
@BraisGabin BraisGabin deleted the show-raw-string-ingentation branch August 3, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api core formatting housekeeping Marker for housekeeping tasks and refactorings rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants