Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proper globbing in ReturnCount #5118

Merged
merged 3 commits into from Aug 1, 2022
Merged

Conversation

BraisGabin
Copy link
Collaborator

SplitPattern has a partial/funky support for glob patterns. This PR changes that to a proper implementation using simplePatternToRegex.

@github-actions github-actions bot added the rules label Jul 23, 2022
@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #5118 (f0f1c9a) into main (13d823c) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Current head f0f1c9a differs from pull request most recent head 1af95ed. Consider uploading reports for the commit 1af95ed to get more accurate results

@@             Coverage Diff              @@
##               main    #5118      +/-   ##
============================================
- Coverage     84.91%   84.91%   -0.01%     
- Complexity     3613     3614       +1     
============================================
  Files           502      502              
  Lines         11884    11889       +5     
  Branches       2236     2239       +3     
============================================
+ Hits          10091    10095       +4     
  Misses          690      690              
- Partials       1103     1104       +1     
Impacted Files Coverage Δ
...itlab/arturbosch/detekt/rules/style/ReturnCount.kt 91.30% <75.00%> (-1.88%) ⬇️
...turbosch/detekt/rules/style/ForbiddenMethodCall.kt 91.66% <0.00%> (+0.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

BraisGabin and others added 2 commits August 1, 2022 18:13
…/rules/style/ReturnCount.kt

Co-authored-by: marschwar <marschwar@users.noreply.github.com>
@BraisGabin BraisGabin enabled auto-merge (squash) August 1, 2022 16:14
@BraisGabin BraisGabin merged commit 090b5bc into main Aug 1, 2022
18 of 19 checks passed
@BraisGabin BraisGabin deleted the support-proper-glob branch August 1, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants